Implement ping pong in timer for keeping connection alive #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aisstream
reviewed
May 11, 2025
| explicit AisStreamClient(QObject* parent = nullptr); | ||
|
|
||
| private Q_SLOTS: | ||
| // private Q_SLOTS: |
Owner
There was a problem hiding this comment.
Should this remain a comment ?
Author
|
Since we only using the "New Signal Slot Syntax" which uses function pointers
(not the string based) for Qt5 it is not necessary to have the macro
Q_SLOTS it only gives some overhead
https://wiki.qt.io/New_Signal_Slot_Syntax
/Fredrik Axling
…On mån maj 12 01:16:48 2025, aisstream.io wrote:
@aisstream commented on this pull request.
In c++/qt.cpp:
> @@ -10,14 +10,20 @@ class AisStreamClient : public QObject
public:
explicit AisStreamClient(QObject* parent = nullptr);
-private Q_SLOTS:
+// private Q_SLOTS:
Should this remain a comment ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.